Discussion:
Roller 5.2.0-rc-4 available for review
Dave
2017-10-14 21:04:51 UTC
Permalink
I've prepared a fourth release candidate for Roller 5.2.0. This release is
primarily a bug fix release, with lots of fixes from Kohei and others. I
have created a release candidate which you can find here:

https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-4/

And the list of issues resolved in 5.2.0 is here:


https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310906&version=12340980

Thanks again to Greg and Kohei for finding some issues in the previous RCs.
I believe I have fixed all the problems found so far. Here's what has
changed since rc-3:

1. Added missing Struts action names to struts.xml
2. Explicity list directories to be included in release (removes
extraneous files)
3. Removed duplicate ROME fetcher dependency
4. Fixed Maven Resource "filtering" problem in roller.properties
5. Add missing log4j-core dependency, needed by Log4J2
6. Reduce Log4j2 logging level to "warn" for Struts2


I'm currently running this code on rollerweblogger.org and it seems to be
working well.

Please take a look when you get a chance and I will call for a vote in 3-4
days.

Thanks,
Dave
Glen Mazza
2017-10-15 02:45:20 UTC
Permalink
When I was about to deploy TightBlog on Linode, I noticed the Linode
terms (if I recall correctly) required any email sending system to
provide an ability for people who have signed up for something to
unsubscribe for what they signed up for, something quite reasonable that
I had overlooked in my Roller fork. As a result, I had to make a patch
release of TB to provide an unsubscribe link in notification emails for
those who checked "notify me" for blog comments before I could deploy
it. Roller may wish to add similar functionality in its own product, as
it is otherwise a show-stopper for hosting providers having similar
requirements.

Glen
Post by Dave
I've prepared a fourth release candidate for Roller 5.2.0. This release is
primarily a bug fix release, with lots of fixes from Kohei and others. I
https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-4/
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310906&version=12340980
Thanks again to Greg and Kohei for finding some issues in the previous RCs.
I believe I have fixed all the problems found so far. Here's what has
1. Added missing Struts action names to struts.xml
2. Explicity list directories to be included in release (removes
extraneous files)
3. Removed duplicate ROME fetcher dependency
4. Fixed Maven Resource "filtering" problem in roller.properties
5. Add missing log4j-core dependency, needed by Log4J2
6. Reduce Log4j2 logging level to "warn" for Struts2
I'm currently running this code on rollerweblogger.org and it seems to be
working well.
Please take a look when you get a chance and I will call for a vote in 3-4
days.
Thanks,
Dave
Greg Huber
2017-10-15 09:58:54 UTC
Permalink
Dave,

Looks good. The only thing are these errors in the log files :


10:51:04.724 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in the
ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
could not locate the message resource with key 'currentDirectory.name'
10:51:04.724 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in the
ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
could not locate the message resource with key 'currentDirectory.name'
10:51:04.728 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value expression
'currentDirectory.name' was evaluated and did not match a property. The
literal value 'currentDirectory.name' will be used.

Cheers Greg
Post by Dave
I've prepared a fourth release candidate for Roller 5.2.0. This release is
primarily a bug fix release, with lots of fixes from Kohei and others. I
https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-4/
https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12310906&version=12340980
Thanks again to Greg and Kohei for finding some issues in the previous RCs.
I believe I have fixed all the problems found so far. Here's what has
1. Added missing Struts action names to struts.xml
2. Explicity list directories to be included in release (removes
extraneous files)
3. Removed duplicate ROME fetcher dependency
4. Fixed Maven Resource "filtering" problem in roller.properties
5. Add missing log4j-core dependency, needed by Log4J2
6. Reduce Log4j2 logging level to "warn" for Struts2
I'm currently running this code on rollerweblogger.org and it seems to be
working well.
Please take a look when you get a chance and I will call for a vote in 3-4
days.
Thanks,
Dave
Dave
2017-10-15 22:38:09 UTC
Permalink
Thanks Greg!

There is now a fifth release candiate with these changes since the last:
- Correct Struts2 syntax for displaying currentDirectory.name on media
file view page
- Add missing allowed-action for blog membership "accept" action
- Several fixes to Planet Group save, edit and delete
- Commented out @AllowedActions annotations since they don't work

You can find rc-5 here:
https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-5/

Please take a look if you have a chance. I plan to call for a vote next
weekend.

Cheers,
Dave
Post by Greg Huber
Dave,
10:51:04.724 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in the
ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
could not locate the message resource with key 'currentDirectory.name'
10:51:04.724 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in the
ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
could not locate the message resource with key 'currentDirectory.name'
10:51:04.728 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value expression
'currentDirectory.name' was evaluated and did not match a property. The
literal value 'currentDirectory.name' will be used.
Cheers Greg
Post by Dave
I've prepared a fourth release candidate for Roller 5.2.0. This release
is
Post by Dave
primarily a bug fix release, with lots of fixes from Kohei and others. I
https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-4/
Post by Dave
https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12310906&version=12340980
Thanks again to Greg and Kohei for finding some issues in the previous
RCs.
Post by Dave
I believe I have fixed all the problems found so far. Here's what has
1. Added missing Struts action names to struts.xml
2. Explicity list directories to be included in release (removes
extraneous files)
3. Removed duplicate ROME fetcher dependency
4. Fixed Maven Resource "filtering" problem in roller.properties
5. Add missing log4j-core dependency, needed by Log4J2
6. Reduce Log4j2 logging level to "warn" for Struts2
I'm currently running this code on rollerweblogger.org and it seems to
be
Post by Dave
working well.
Please take a look when you get a chance and I will call for a vote in
3-4
Post by Dave
days.
Thanks,
Dave
Greg Huber
2017-10-16 07:55:38 UTC
Permalink
Dave,

Went through and rechecked the allows as may have missed some from your
email on the re blog roll. Just one more:


Method disable for action pings is not allowed!


Otherwise +1

Cheers Greg
Post by Dave
Thanks Greg!
- Correct Struts2 syntax for displaying currentDirectory.name on media
file view page
- Add missing allowed-action for blog membership "accept" action
- Several fixes to Planet Group save, edit and delete
https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-5/
Please take a look if you have a chance. I plan to call for a vote next
weekend.
Cheers,
Dave
Post by Greg Huber
Dave,
10:51:04.724 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the
Post by Greg Huber
ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
could not locate the message resource with key 'currentDirectory.name'
10:51:04.724 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the
Post by Greg Huber
ValueStack (org.apache.roller.weblogger.ui.struts2.editor.MediaFileView)
could not locate the message resource with key 'currentDirectory.name'
10:51:04.728 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression
Post by Greg Huber
'currentDirectory.name' was evaluated and did not match a property. The
literal value 'currentDirectory.name' will be used.
Cheers Greg
Post by Dave
I've prepared a fourth release candidate for Roller 5.2.0. This release
is
Post by Dave
primarily a bug fix release, with lots of fixes from Kohei and others.
I
Post by Greg Huber
https://dist.apache.org/repos/dist/dev/roller/roller-5.2/v5.2.0-rc-4/
Post by Dave
https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12310906&version=12340980
Thanks again to Greg and Kohei for finding some issues in the previous
RCs.
Post by Dave
I believe I have fixed all the problems found so far. Here's what has
1. Added missing Struts action names to struts.xml
2. Explicity list directories to be included in release (removes
extraneous files)
3. Removed duplicate ROME fetcher dependency
4. Fixed Maven Resource "filtering" problem in roller.properties
5. Add missing log4j-core dependency, needed by Log4J2
6. Reduce Log4j2 logging level to "warn" for Struts2
I'm currently running this code on rollerweblogger.org and it seems to
be
Post by Dave
working well.
Please take a look when you get a chance and I will call for a vote in
3-4
Post by Dave
days.
Thanks,
Dave
Loading...